Fix node scope resolving of array/list expression assignments #1405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7119
By always calling
Scope::enterExpressionAssign
when$enterExpressionAssign
is set,ClassStatementsGatherer::gatherNodes
can correctly skip creatingPropertyRead
on assignments in https://github.com/phpstan/phpstan-src/blob/1.7.11/src/Node/ClassStatementsGatherer.php#L186.If I'm not completely confused by array destructuring assignments now, then the 2 new reported errors from
UnusedPrivatePropertyRuleTest
were previously missed and should be correct.